-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/145 chondro replace #156
Conversation
…poly.below() without the need for chondro.
…perSpec into feature/145-chondro-replace
…perSpec into feature/145-chondro-replace
avoids error on empty label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eoduniyi When I try to check this branch I get a message that flu
is not exported. Strangely, I don't think you touched flu.R
but it does not have an @export
statement. Since you can build/check/install perhaps this is a problem with my local files.
Yo u are correct, I did not touch |
Usually, the documentation of dataset should not have
|
@eoduniyi, in r-hyperspec/hySpc.dplyr#23 (comment), I wrote about the "magical" words (fix, fixes, close, closes, resolve, resolves) that make PR to close an issue. These words work only in the main message of PR. So I updated your the main PR (pull request) message with: |
I can confirm, that word
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As code passes R-CMD-check and chondro
was removed from all necessary places, I approve this PR ✔️
chondro
has been replaced withfauxCell
in all the .R files (examples; unit test) that referencechondro
Note: vignettes still makes use of
chondro
Closes #145